Add store_bdg, SPMR, broad parameters for calling peaks using MACS3 #329
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Kai,
I add three parameters for peak calling.
On bed graph generation:
On broad peak calling:
But I am not sure if this is enough for the peak calling function since I notice that you actually have a rust layer for the real task.
Another question I have: there is
nomodel
parameter in the list. According the MACS3 README, it seems to be needed forextsize
parameter.By default, I set all of them false in order to keep the default behavior of your function.
Thanks!
Songpeng