1721 enki convert image #96
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmykarily
force-pushed
the
1721-enki-convert-image
branch
2 times, most recently
from
40d66ca
to
3198c14
Compare
jimmykarily
force-pushed
the
1721-enki-convert-image
branch
from
a412fcc
to
8a4d580
Compare
Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Dimitris Karakasilis <[email protected]>
In other words, don't run `RUN` commands that might not be there. Ideally all `RUN` commands should run on the builder stage and at the final step, we just copy everything over. Signed-off-by: Dimitris Karakasilis <[email protected]>
jimmykarily
force-pushed
the
1721-enki-convert-image
branch
from
8a4d580
to
2f0d06b
Compare
Signed-off-by: Dimitris Karakasilis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: kairos-io/kairos#1721