Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip audit preprocessing if there's nowhere to log #94

Merged
merged 2 commits into from
Feb 17, 2024
Merged

Conversation

Haarolean
Copy link
Member

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@Haarolean Haarolean added type/enhancement En enhancement/improvement to an already existing feature scope/backend Related to backend changes area/audit labels Feb 1, 2024
@Haarolean Haarolean added this to the 1.0 milestone Feb 1, 2024
@Haarolean Haarolean requested a review from iliax February 1, 2024 13:24
@Haarolean Haarolean self-assigned this Feb 1, 2024
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress type/feature A brand new feature status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Feb 1, 2024
@Haarolean Haarolean changed the title Skip auditing preprocessing if there's nowhere to log Skip audit preprocessing if there's nowhere to log Feb 1, 2024
@Haarolean Haarolean removed status/triage/manual Manual triage in progress type/feature A brand new feature labels Feb 1, 2024
Copy link
Contributor

@iliax iliax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use {} in if

@Haarolean Haarolean merged commit a8d111e into main Feb 17, 2024
2 of 6 checks passed
@Haarolean Haarolean deleted the enh/skip_audit branch February 17, 2024 11:45
@Haarolean Haarolean added type/chore Boring stuff, could be refactoring or tech debt and removed type/enhancement En enhancement/improvement to an already existing feature labels Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/audit scope/backend Related to backend changes status/triage/completed Automatic triage completed type/chore Boring stuff, could be refactoring or tech debt
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants