Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: add run configurations to improve the dev experience locally #724

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

yeikel
Copy link
Contributor

@yeikel yeikel commented Dec 23, 2024

What changes did you make? (Give an overview)

Configures a set of default Run Configuration for IntelliJ IDEA to improve the development experience locally. Now, when a developer clones and runs the project, a set of default run configurations are included by default

  1. A default run configuration for Spring with the VM arguments --add-opens java.rmi/javax.rmi.ssl=ALL-UNNAMED that are needed to launch the application

CMD java --add-opens java.rmi/javax.rmi.ssl=ALL-UNNAMED $JAVA_OPTS -jar api.jar

  1. Lauch Dependencies : Adds a Docker compose configuration to launch all the dependencies calling docker compose up documentation/compose/e2e-tests.yaml

  2. Adds a TestNG template for IntelliJ to ensure that integration test execution include -Dheadless=false -Dselenoid=false automatically. This configuration avoids running Selenoid and running a real Chrome instance following the definition in

    public static final boolean HEADLESS = parseBoolean(getOptionalString(TRUE, System.getProperty("headless")));
    public static final boolean SELENOID = parseBoolean(getOptionalString(TRUE, System.getProperty("selenoid")));

Now, when we run any Smoke test in IntelliJ IDEA should add the -Dheadless=false -Dselenoid=false arguments automatically under VM Options

image

In an ideal world, running this step should launch E2E Dependencies as well but sadly that's blocking due to the following issues:

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • Manually (please, describe, if necessary)

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code

A picture of a cute animal (not mandatory but encouraged)

Cuban-Trogon-800-Michael-Klotz-CC

@yeikel yeikel requested a review from a team as a code owner December 23, 2024 17:41
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Dec 23, 2024
@yeikel yeikel changed the title Chore: Add test template Chore: Add integration test template Dec 23, 2024
@yeikel yeikel changed the title Chore: Add integration test template Chore: Add integration test template to improve dev experience locally Dec 23, 2024
@yeikel yeikel marked this pull request as draft December 23, 2024 17:48
@yeikel yeikel changed the title Chore: Add integration test template to improve dev experience locally Chore: add run configurations to improve the dev experience locally Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/triage/completed Automatic triage completed status/triage/manual Manual triage in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant