Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BE: KC: Expose Kafka Connect validation errors in the UI #705

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

yeikel
Copy link
Contributor

@yeikel yeikel commented Dec 12, 2024

What changes did you make? (Give an overview)

Closes #681

Example:

image

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

A picture of a cute animal (not mandatory but encouraged)

image

@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Dec 12, 2024
@yeikel yeikel force-pushed the expose-error branch 6 times, most recently from c5a49d1 to eadf510 Compare December 12, 2024 06:06
etc/checkstyle/checkstyle.xml Outdated Show resolved Hide resolved
@yeikel yeikel marked this pull request as ready for review December 12, 2024 06:09
@yeikel yeikel requested review from a team as code owners December 12, 2024 06:09
Copy link
Member

@Haarolean Haarolean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks much for implementing this, experiencing this issue wasn't very pleasant when working with KC :)

etc/checkstyle/checkstyle.xml Outdated Show resolved Hide resolved
@Haarolean Haarolean changed the title BE: Expose Kafka Connect validation errors in the UI BE: KC: Expose Kafka Connect validation errors in the UI Dec 12, 2024
@Haarolean Haarolean added type/enhancement En enhancement/improvement to an already existing feature scope/backend Related to backend changes area/connect Kafka Connect, its connectors and removed status/triage/manual Manual triage in progress labels Dec 12, 2024
@yeikel yeikel force-pushed the expose-error branch 7 times, most recently from f44d83c to 01055b8 Compare December 12, 2024 15:07
@yeikel
Copy link
Contributor Author

yeikel commented Dec 12, 2024

@Haarolean Please take a second look 🙇

I opted for the first suggestion and used @SuppressWarnings("checkstyle:LineLength") because I think that checkstyle should not limit the language features we get access to or decrease the readability of the code. Text blocks, in my opinion, make the test more readable than workarounds using concatenation

@yeikel
Copy link
Contributor Author

yeikel commented Dec 12, 2024

@Haarolean Are the current test failures a known problem?

@Haarolean
Copy link
Member

@yeikel yeah it's a flaky one

@Haarolean Haarolean merged commit d507a9f into kafbat:main Dec 12, 2024
11 of 13 checks passed
@Haarolean
Copy link
Member

@yeikel thank you!

@yeikel yeikel deleted the expose-error branch December 12, 2024 17:00
K-Diger pushed a commit to K-Diger/kafbat-kafka-ui that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connect Kafka Connect, its connectors scope/backend Related to backend changes status/triage/completed Automatic triage completed type/enhancement En enhancement/improvement to an already existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KC: Expose validation errors to UI
2 participants