Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BE: Chore: use enhanced switch #702

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

yeikel
Copy link
Contributor

@yeikel yeikel commented Dec 10, 2024

A small change to take advantage of newer language features

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • Unit checks

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

A picture of a cute animal (not mandatory but encouraged)

is-this-smile-cute-or-terrifying-photo-u1

@yeikel yeikel requested a review from a team as a code owner December 10, 2024 16:42
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Dec 10, 2024
@yeikel yeikel force-pushed the refactor-enhanced-switch branch from 9d518e9 to 66224a3 Compare December 11, 2024 17:59
@Haarolean Haarolean added scope/backend Related to backend changes type/chore Boring stuff, could be refactoring or tech debt and removed status/triage/manual Manual triage in progress labels Dec 12, 2024
@Haarolean Haarolean added this to the 1.1 milestone Dec 12, 2024
@yeikel yeikel force-pushed the refactor-enhanced-switch branch from 66224a3 to c448143 Compare December 13, 2024 05:17
@yeikel
Copy link
Contributor Author

yeikel commented Dec 13, 2024

@Haarolean Can we merge this? It should be ready to go as far as I know

@Haarolean Haarolean merged commit 07c694f into kafbat:main Dec 15, 2024
11 of 13 checks passed
@yeikel yeikel deleted the refactor-enhanced-switch branch December 15, 2024 21:53
K-Diger pushed a commit to K-Diger/kafbat-kafka-ui that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/backend Related to backend changes status/triage/completed Automatic triage completed type/chore Boring stuff, could be refactoring or tech debt
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants