Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infra: Fix e2e compose #655

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Infra: Fix e2e compose #655

merged 1 commit into from
Nov 11, 2024

Conversation

Haarolean
Copy link
Member

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@Haarolean Haarolean self-assigned this Nov 11, 2024
@Haarolean Haarolean requested a review from a team as a code owner November 11, 2024 10:09
@kapybro kapybro bot added status/triage Issues pending maintainers triage scope/infra CI, CD, dev. env, etc. status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Nov 11, 2024
@Haarolean Haarolean added the type/bug Something isn't working label Nov 11, 2024
@Haarolean Haarolean merged commit 10d4a11 into main Nov 11, 2024
26 of 27 checks passed
@Haarolean Haarolean deleted the chore/fix-e2e branch November 11, 2024 15:18
@credmond
Copy link

Why not fix the other compose files at the same time?

@Haarolean
Copy link
Member Author

@credmond my bad, for some reason I thought that's the last zk-less one. Wanna raise a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/infra CI, CD, dev. env, etc. status/triage/completed Automatic triage completed type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants