FE: Implement previous button in topic messages page #550

hadisfr · 2024-09-17T15:38:21Z

Breaking change?

What changes did you make?

This PR adds the Previous button to the topic messages page.
This button used to be there in the provectus version, but was broken and has been removed in kafbat since migration to messages API v2.

This PR somehow addresses #270.

Is there anything you'd like reviewers to focus on?

How Has This Been Tested?

No need to
Manually (please, describe, if necessary)
Unit checks
Integration checks
Covered by existing automation

We checked the aforementioned page extensively and ran the maven tests.

Checklist

I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
My changes generate no new warnings (e.g. Sonar is happy)
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal

P.S. Sorry but it seems that I don't have access to set label nor to ask a reviewer to review my changes, as requested in docs.
Also, checking all boxes of "How Has This Been Tested" seems irrelevant, but it causes failure of automatic check of PR.

github-actions

Hi hadisfr! 👋

Welcome, and thank you for opening your first PR in the repo!

Please wait for triaging by our maintainers.

Please take a look at our contributing guide.

…#550)

)

…mode (kafbat#550)

kafbat#550)

GagananandiC · 2024-09-20T05:02:07Z

Waiting for this change to get available.

…#550)

)

…mode (kafbat#550)

kafbat#550)

…#550)

)

…mode (kafbat#550)

kafbat#550)

hadisfr · 2024-09-29T06:28:05Z

Hi!
Any news on this PR? @iliax @Haarolean

GagananandiC · 2024-10-07T06:15:57Z

Hello @Haarolean @iliax ,
when can we have this in Release ?

Haarolean · 2024-10-16T21:24:54Z

api/src/test/java/io/kafbat/ui/service/MessagesServiceTest.java

@@ -147,7 +147,7 @@ void cursorIsRegisteredAfterPollingIsDoneAndCanBeUsedForNextPagePolling(PollingM
    Flux<String> remainingMsgs = messagesService.loadMessages(cluster, testTopic, cursorIdCatcher.get())
        .doOnNext(evt -> {
          if (evt.getType() == TopicMessageEventDTO.TypeEnum.DONE) {
-            assertThat(evt.getCursor()).isNull();
+            assertThat(evt.getNextCursor()).isNull();


@hadisfr can we add some tests for the new backward cursor here?

hadisfr requested review from a team as code owners September 17, 2024 15:38

kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress area/messages status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Sep 17, 2024

github-actions bot reviewed Sep 17, 2024

View reviewed changes

hadisfr added a commit to hadisfr/kafka-ui that referenced this pull request Sep 17, 2024

FE: Refactor topic messages next page codebase (kafbat#550)

22da860

hadisfr added a commit to hadisfr/kafka-ui that referenced this pull request Sep 17, 2024

FE: Rename cursor to nextCursor in topic message response (kafbat#550)

55fc250

hadisfr added a commit to hadisfr/kafka-ui that referenced this pull request Sep 17, 2024

FE: Add Prevoius button to topic message page - frontend side (kafbat…

7d68c19

…#550)

hadisfr force-pushed the feature/previous_button_in_topic_messages_page branch from 89021aa to 2e81741 Compare September 17, 2024 15:39

hadisfr added a commit to hadisfr/kafka-ui that referenced this pull request Sep 17, 2024

FE: Add Prevoius button to topic message page - backend side (kafbat#550

6493775

)

hadisfr added a commit to hadisfr/kafka-ui that referenced this pull request Sep 17, 2024

FE: Handle previousCursor in first page (kafbat#550)

410826e

hadisfr added a commit to hadisfr/kafka-ui that referenced this pull request Sep 17, 2024

FE: fix missing previousCursorId in case of empty pollRange (kafbat#550)

50aa173

hadisfr added a commit to hadisfr/kafka-ui that referenced this pull request Sep 17, 2024

FE: Reset page parameter in URL of topic messages page when changing …

c1d4f92

…mode (kafbat#550)

hadisfr added a commit to hadisfr/kafka-ui that referenced this pull request Sep 17, 2024

FE: fix a null pointer exception due to test fixtures (kafbat#550)

2e81741

hadisfr added a commit to hadisfr/kafka-ui that referenced this pull request Sep 18, 2024

FE: Fix linter warnings (kafbat#550)

24ded3c

hadisfr added a commit to hadisfr/kafka-ui that referenced this pull request Sep 18, 2024

FE: Fix linter warnings (kafbat#550)

38bfce3

hadisfr added a commit to hadisfr/kafka-ui that referenced this pull request Sep 18, 2024

FE: Fix frontend test fixtures (kafbat#550)

cda3769

hadisfr added a commit to hadisfr/kafka-ui that referenced this pull request Sep 18, 2024

FE: Add some frontend tests for previous button in topic messages page (

611c55c

kafbat#550)

Haarolean requested a review from iliax September 18, 2024 10:40

Haarolean added type/enhancement En enhancement/improvement to an already existing feature scope/frontend Related to frontend changes scope/backend Related to backend changes and removed status/triage/manual Manual triage in progress labels Sep 18, 2024

hadisfr added a commit to hadisfr/kafka-ui that referenced this pull request Sep 21, 2024

FE: Refactor topic messages next page codebase (kafbat#550)

67e05a9

hadisfr added a commit to hadisfr/kafka-ui that referenced this pull request Sep 21, 2024

FE: Rename cursor to nextCursor in topic message response (kafbat#550)

8b580f5

hadisfr force-pushed the feature/previous_button_in_topic_messages_page branch from 611c55c to d77352a Compare September 21, 2024 10:11

hadisfr added a commit to hadisfr/kafka-ui that referenced this pull request Sep 21, 2024

FE: Add Prevoius button to topic message page - frontend side (kafbat…

ce7e27f

…#550)

hadisfr added a commit to hadisfr/kafka-ui that referenced this pull request Sep 21, 2024

FE: Add Prevoius button to topic message page - backend side (kafbat#550

bd4fb36

)

hadisfr added a commit to hadisfr/kafka-ui that referenced this pull request Sep 21, 2024

FE: Handle previousCursor in first page (kafbat#550)

52a7241

hadisfr added a commit to hadisfr/kafka-ui that referenced this pull request Sep 21, 2024

FE: fix missing previousCursorId in case of empty pollRange (kafbat#550)

ac60cdf

hadisfr added a commit to hadisfr/kafka-ui that referenced this pull request Sep 21, 2024

FE: Reset page parameter in URL of topic messages page when changing …

95da4a4

…mode (kafbat#550)

hadisfr added a commit to hadisfr/kafka-ui that referenced this pull request Sep 21, 2024

FE: fix a null pointer exception due to test fixtures (kafbat#550)

6575d07

hadisfr added a commit to hadisfr/kafka-ui that referenced this pull request Sep 21, 2024

FE: Fix linter warnings (kafbat#550)

2729103

hadisfr added a commit to hadisfr/kafka-ui that referenced this pull request Sep 21, 2024

FE: Fix linter warnings (kafbat#550)

197b542

hadisfr added a commit to hadisfr/kafka-ui that referenced this pull request Sep 21, 2024

FE: Fix frontend test fixtures (kafbat#550)

bdb6670

hadisfr added a commit to hadisfr/kafka-ui that referenced this pull request Sep 21, 2024

FE: Add some frontend tests for previous button in topic messages page (

d77352a

kafbat#550)

hadisfr added 12 commits September 28, 2024 19:31

FE: Refactor topic messages next page codebase (kafbat#550)

9971ab3

FE: Rename cursor to nextCursor in topic message response (kafbat#550)

fa615f3

FE: Add Prevoius button to topic message page - frontend side (kafbat…

97c5eac

…#550)

FE: Add Prevoius button to topic message page - backend side (kafbat#550

610de42

)

FE: Handle previousCursor in first page (kafbat#550)

085302f

FE: fix missing previousCursorId in case of empty pollRange (kafbat#550)

d443363

FE: Reset page parameter in URL of topic messages page when changing …

5f1db17

…mode (kafbat#550)

FE: fix a null pointer exception due to test fixtures (kafbat#550)

303d7be

FE: Fix linter warnings (kafbat#550)

a783c6f

FE: Fix linter warnings (kafbat#550)

ff8e83c

FE: Fix frontend test fixtures (kafbat#550)

64cd1f6

FE: Add some frontend tests for previous button in topic messages page (

40c6f0b

kafbat#550)

hadisfr force-pushed the feature/previous_button_in_topic_messages_page branch from d77352a to 40c6f0b Compare September 28, 2024 16:01

Haarolean added the hacktoberfest-accepted PRs accepted towards hacktoberfest goal and will be counted as approved label Oct 4, 2024

Haarolean linked an issue Oct 6, 2024 that may be closed by this pull request

FE: Messages: Add back button in pagination #270

Open

2 tasks

Haarolean reviewed Oct 16, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FE: Implement previous button in topic messages page #550

FE: Implement previous button in topic messages page #550

hadisfr commented Sep 17, 2024 •

edited

Loading

github-actions bot left a comment

GagananandiC commented Sep 20, 2024

hadisfr commented Sep 29, 2024

GagananandiC commented Oct 7, 2024

Haarolean Oct 16, 2024

FE: Implement previous button in topic messages page #550

Are you sure you want to change the base?

FE: Implement previous button in topic messages page #550

Conversation

hadisfr commented Sep 17, 2024 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

GagananandiC commented Sep 20, 2024

hadisfr commented Sep 29, 2024

GagananandiC commented Oct 7, 2024

Haarolean Oct 16, 2024

Choose a reason for hiding this comment

hadisfr commented Sep 17, 2024 •

edited

Loading