Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BE: Make gh version check timeout configurable #518

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

wernerdv
Copy link
Contributor

@wernerdv wernerdv commented Jul 31, 2024

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Fixed #477.

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@wernerdv wernerdv requested a review from a team as a code owner July 31, 2024 20:27
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Jul 31, 2024
@wernerdv wernerdv marked this pull request as draft July 31, 2024 20:46
@wernerdv wernerdv marked this pull request as ready for review July 31, 2024 21:34
@wernerdv
Copy link
Contributor Author

@Haarolean Hello, PTAL.

@wernerdv
Copy link
Contributor Author

@Haarolean PTAL.
Is there anything I can do to improve this PR?

@Haarolean Haarolean added type/enhancement En enhancement/improvement to an already existing feature scope/backend Related to backend changes type/chore Boring stuff, could be refactoring or tech debt and removed status/triage/manual Manual triage in progress type/chore Boring stuff, could be refactoring or tech debt labels Sep 24, 2024
@wernerdv wernerdv requested a review from Haarolean September 24, 2024 19:00
@Haarolean Haarolean merged commit 3f3ca4c into kafbat:main Sep 25, 2024
11 of 12 checks passed
@Haarolean
Copy link
Member

@wernerdv thanks for your contribution!

@wernerdv wernerdv deleted the issues/477 branch September 25, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/backend Related to backend changes status/triage/completed Automatic triage completed type/enhancement En enhancement/improvement to an already existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BE: Make gh version check timeout configurable
2 participants