Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BE: RBAC: Impl separate permissions for topic analysis #513

Merged
merged 6 commits into from
Aug 10, 2024
Merged

BE: RBAC: Impl separate permissions for topic analysis #513

merged 6 commits into from
Aug 10, 2024

Conversation

bachmanity1
Copy link
Contributor

@bachmanity1 bachmanity1 commented Jul 30, 2024 •
edited
Loading

Resolves #512.

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@bachmanity1 bachmanity1 requested review from a team as code owners July 30, 2024 10:08
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress type/feature A brand new feature status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Jul 30, 2024
github-actions[bot]
github-actions bot reviewed Jul 30, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi bachmanity1! 👋

Welcome, and thank you for opening your first PR in the repo!

Please wait for triaging by our maintainers.

Please take a look at our contributing guide.

@bachmanity1
Copy link
Contributor Author

Hi @Haarolean , can you have a look please?

Haarolean
Haarolean requested changes Jul 30, 2024
View reviewed changes
Copy link
Member

@Haarolean Haarolean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd need changes on the backend as well (see TopicsController class)

@Haarolean Haarolean added type/enhancement En enhancement/improvement to an already existing feature scope/frontend Related to frontend changes scope/backend Related to backend changes and removed type/feature A brand new feature status/triage/manual Manual triage in progress labels Jul 30, 2024
@bachmanity1 bachmanity1 requested a review from Haarolean July 31, 2024 02:09
@bachmanity1 bachmanity1 requested a review from Haarolean July 31, 2024 09:43
@bachmanity1 bachmanity1 requested a review from Haarolean August 5, 2024 02:30
@bachmanity1 bachmanity1 changed the title FE: restrict access to the topic analysis feature Restrict access to the topic analysis feature Aug 5, 2024
@bachmanity1
Copy link
Contributor Author

@Haarolean can we get this merged?

@Haarolean
Copy link
Member

@Haarolean can we get this merged?

as soon as we figure out the backward compatibility drawbacks

@Haarolean Haarolean assigned Haarolean and unassigned bachmanity1 Aug 7, 2024
@Haarolean Haarolean changed the title Restrict access to the topic analysis feature BE: RBAC: Impl separate permissions for topic analysis Aug 10, 2024
@Haarolean Haarolean added the impact/changelog A PR with changes which should be addressed in the changelog explicitly label Aug 10, 2024
@Haarolean Haarolean merged commit 273e64c into kafbat:main Aug 10, 2024
12 of 14 checks passed
@Haarolean
Copy link
Member

@bachmanity1 thanks for your first contribution to kafbat UI!

@bachmanity1 bachmanity1 deleted the feature/512 branch August 10, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Haarolean Haarolean Haarolean approved these changes

Assignees

@Haarolean Haarolean

Labels
impact/changelog A PR with changes which should be addressed in the changelog explicitly scope/backend Related to backend changes scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/enhancement En enhancement/improvement to an already existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BE: RBAC: Impl separate permissions for topic analysis
2 participants
@bachmanity1 @Haarolean