-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BE: Chore: Use dto builders in controller package #504
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the openapi DTOs, I'd prefer to have builders rather than bulky constructors. As the built-in ones are deprecated for some reason, can I suggest adjusting openapi configuration adding additionalModelTypeAnnotations with lombok builder annotations?
BE: Cleanup in controller package
d8cb677
to
5f00885
Compare
@Haarolean Fixed |
@wernerdv thanks for your contribution! |
What changes did you make? (Give an overview)
A little cleanup in the controller package.
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)