Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BE: RBAC: Ignore values for non-applicable resources #503

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wernerdv
Copy link
Contributor

@wernerdv wernerdv commented Jul 26, 2024

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Fixed #253

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@wernerdv wernerdv requested a review from a team as a code owner July 26, 2024 20:08
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress area/rbac Related to Role Based Access Control feature status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Jul 26, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi wernerdv! 👋

Welcome, and thank you for opening your first PR in the repo!

Please wait for triaging by our maintainers.

Please take a look at our contributing guide.

@wernerdv wernerdv force-pushed the ignore_non_allowed_values branch from 99dada9 to 31061c0 Compare September 20, 2024 08:05
@wernerdv
Copy link
Contributor Author

wernerdv commented Sep 26, 2024

@Haarolean Can you tell me if a unit test is needed for this refinement?
Is there anything I can do to improve PR (for example adding logging)?

@Haarolean
Copy link
Member

Haarolean commented Sep 27, 2024

@wernerdv I was hesitant to merge this as I thought there might be some other corner cases and given we don't have tests for RBAC at all, I have to eyeball this as much as possible. I wouldn't push you to write all the tests for RBAC within the scope of this issue.

@Haarolean Haarolean self-assigned this Sep 27, 2024
@Haarolean Haarolean added the hacktoberfest-accepted PRs accepted towards hacktoberfest goal and will be counted as approved label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/rbac Related to Role Based Access Control feature hacktoberfest-accepted PRs accepted towards hacktoberfest goal and will be counted as approved status/triage/completed Automatic triage completed status/triage/manual Manual triage in progress
Projects
Status: Revisit
Development

Successfully merging this pull request may close these issues.

BE: RBAC: Ignore values for non-applicable resources
2 participants