Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BE: Implement a mechanism to skip SSL verification #422

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

BE: Implement a mechanism to skip SSL verification #422

wants to merge 2 commits into from

Conversation

Haarolean
Copy link
Member

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Resolves #53

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@Haarolean Haarolean added type/enhancement En enhancement/improvement to an already existing feature scope/backend Related to backend changes labels May 25, 2024
@Haarolean Haarolean self-assigned this May 25, 2024
@Haarolean Haarolean requested a review from a team as a code owner May 25, 2024 23:22
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels May 25, 2024
@fallen-up fallen-up mentioned this pull request Jun 4, 2024
Closed
2 tasks
@Haarolean Haarolean added the hacktoberfest-accepted PRs accepted towards hacktoberfest goal and will be counted as approved label Oct 4, 2024
@baonq-me

This comment has been minimized.

Sign in to view
Haarolean
Haarolean commented Dec 7, 2024
View reviewed changes
api/src/main/java/io/kafbat/ui/config/ClustersProperties.java
@@ -99,6 +108,16 @@ public static class SchemaRegistryAuth {
public static class TruststoreConfig {
String truststoreLocation;
String truststorePassword;
boolean verifySsl = true;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • add this property to contracts
  • update docs to include this property

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@germanosin germanosin germanosin approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@Haarolean Haarolean

Labels
hacktoberfest-accepted PRs accepted towards hacktoberfest goal and will be counted as approved scope/backend Related to backend changes status/triage/completed Automatic triage completed type/enhancement En enhancement/improvement to an already existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BE: Implement a mechanism to skip SSL verification
3 participants
@Haarolean @baonq-me @germanosin