Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infra: Fix checkout permissions #28

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Conversation

mrmoonl1ght94
Copy link
Contributor

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@github-actions github-actions bot added the status/triage Issues pending maintainers triage label Jan 23, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there mrmoonl1ght94! 👋

Thank you and congrats 🎉 for opening your first PR on this project! ✨ 💖

We will try to review it soon!

@Haarolean Haarolean added scope/infra CI, CD, dev. env, etc. and removed status/triage Issues pending maintainers triage labels Jan 23, 2024
@Haarolean Haarolean self-requested a review January 23, 2024 16:03
@Haarolean Haarolean merged commit 9186cd0 into main Jan 23, 2024
8 of 11 checks passed
@Haarolean Haarolean deleted the infra/fix-permissions-for-checkout branch January 23, 2024 16:03
@Haarolean Haarolean changed the title Infra/fix permissions for checkout Infra: Fix checkout permissions Mar 7, 2024
@Haarolean Haarolean added the type/chore Boring stuff, could be refactoring or tech debt label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/infra CI, CD, dev. env, etc. type/chore Boring stuff, could be refactoring or tech debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants