Skip to content

Commit

Permalink
removed skipUIbuild, declared frontend as separate maven module with …
Browse files Browse the repository at this point in the history
…pom packaging
  • Loading branch information
KliminV committed Dec 3, 2024
1 parent 6471027 commit b1e2e1e
Show file tree
Hide file tree
Showing 3 changed files with 66 additions and 12 deletions.
11 changes: 0 additions & 11 deletions api/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
<sonar.jacoco.reportPath>${project.basedir}/target/jacoco.exec</sonar.jacoco.reportPath>
<sonar.coverage.jacoco.xmlReportPaths>${project.basedir}/target/site/jacoco/jacoco.xml</sonar.coverage.jacoco.xmlReportPaths>
<sonar.language>java</sonar.language>
<skipUIBuild>true</skipUIBuild>
</properties>

<dependencies>
Expand Down Expand Up @@ -405,7 +404,6 @@
<artifactId>frontend-maven-plugin</artifactId>
<version>${frontend-maven-plugin.version}</version>
<configuration>
<skip>${skipUIBuild}</skip>
<workingDirectory>../frontend</workingDirectory>
<environmentVariables>
<VITE_TAG>${project.version}</VITE_TAG>
Expand Down Expand Up @@ -447,17 +445,8 @@
</build>

<profiles>
<profile>
<id>local</id>
<properties>
<skipUIBuild>false</skipUIBuild>
</properties>
</profile>
<profile>
<id>prod</id>
<properties>
<skipUIBuild>false</skipUIBuild>
</properties>
<build>
<plugins>
<plugin>
Expand Down
61 changes: 61 additions & 0 deletions frontend/pom.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<parent>
<artifactId>kafbat-ui</artifactId>
<groupId>io.kafbat.ui</groupId>
<version>0.0.1-SNAPSHOT</version>
</parent>
<packaging>pom</packaging>
<modelVersion>4.0.0</modelVersion>

<artifactId>frontend</artifactId>

<build>
<plugins>
<plugin>
<groupId>com.github.eirslett</groupId>
<artifactId>frontend-maven-plugin</artifactId>
<version>${frontend-maven-plugin.version}</version>
<configuration>
<environmentVariables>
<VITE_TAG>${project.version}</VITE_TAG>
<VITE_COMMIT>${git.commit.id.abbrev}</VITE_COMMIT>
</environmentVariables>
</configuration>
<executions>
<execution>
<id>install node and pnpm</id>
<goals>
<goal>install-node-and-pnpm</goal>
</goals>
<configuration>
<nodeVersion>${node.version}</nodeVersion>
<pnpmVersion>${pnpm.version}</pnpmVersion>
</configuration>
</execution>
<execution>
<id>pnpm install</id>
<goals>
<goal>pnpm</goal>
</goals>
<configuration>
<arguments>install</arguments>
</configuration>
</execution>
<execution>
<id>pnpm build</id>
<goals>
<goal>pnpm</goal>
</goals>
<configuration>
<arguments>build</arguments>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>

</project>
6 changes: 5 additions & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -194,16 +194,20 @@
<activeByDefault>true</activeByDefault>
</activation>
<modules>
<module>frontend</module>
<module>api</module>
<module>contract</module>
<module>e2e-tests</module>
<module>serde-api</module>
</modules>
</profile>
<profile>
<id>contract</id>
<id>backend</id>
<modules>
<module>api</module>
<module>contract</module>
<module>e2e-tests</module>
<module>serde-api</module>
</modules>
</profile>
</profiles>
Expand Down

0 comments on commit b1e2e1e

Please sign in to comment.