This repository has been archived by the owner on Oct 16, 2021. It is now read-only.
lazy require servers #175
Open
lazy require servers #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Users should still be able to set custom installers like this: https://github.com/kabouzeid/nvim-lspinstall#custom-installer |
|
No problem, we can just treat the server differently depending on whether it is a string or a table. If it's a string, treat it as a module name. If it is a table, treat it as a config. |
Allow configs to be represented as lua modules (strings), which can be required to load the config. This saves having to require all built in configs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLEASE READ BEFORE CREATING THE PR :)
For new install scripts
You need to create one file, and edit two files. See this PR for a good example: https://github.com/kabouzeid/nvim-lspinstall/pull/106/files
Whenever possible, use
local config = require'lspinstall/util'.extract_config('rust_analyzer')to extract the config for your language server from nvim-lspconfig.If they don't have a config for your language server yet, please create a pull request there first.
Don't worry, they are usually quite fast with merging new configs.