KAA-1654: Add CoAP transport to Kaa #1361

elysoly · 2016-12-04T10:38:48Z

I have been working on adding CoAP transport support to Kaa project. Now I pushed final results of my work. Hope to receive your comments about it.

kaa-leeroy · 2016-12-04T10:38:49Z

Can one of the admins verify this patch?

Oldnickus · 2016-12-05T19:39:17Z

@kaa-leeroy test this please

rasendubi

Hi, Elnaz. Thank you for your pull request!

I've done a quick review for the code style compliance—see my inline comments. Please, ask if you need a help in fixing any of them.

rasendubi · 2016-12-08T01:01:02Z

...ent-java-core/src/main/java/org/kaaproject/kaa/client/channel/impl/channels/CoapChannel.java

@@ -0,0 +1,265 @@
+package org.kaaproject.kaa.client.channel.impl.channels;


This file needs Apache license header. Both Jenkins and Travis are currently failing because of missing Apache license headers.

rasendubi · 2016-12-08T01:01:54Z

...ent-java-core/src/main/java/org/kaaproject/kaa/client/channel/impl/channels/CoapChannel.java

+ * Date: 10/24/16
+ * Time: 10:52 AM
+ * To change this template use File | Settings | File Templates.
+ */


Please, remove the auto-generated class header. (git already handles such info much better.)

rasendubi · 2016-12-08T01:02:10Z

...ent-java-core/src/main/java/org/kaaproject/kaa/client/channel/impl/channels/CoapChannel.java

+  private static final String CHANNEL_ID = "default_coap_channel";
+  private KaaDataDemultiplexer demultiplexer;
+  private KaaDataMultiplexer multiplexer;
+  //    private volatile State channelState = State.CLOSED;


Commented-out code is not allowed.

It's always a code smell, you know. Weeks after the next guys does a refactoring and wonders what's the purpose of commented out code, why it is commented, should it be uncommented or deleted?

rasendubi · 2016-12-08T01:02:34Z

...ent-java-core/src/main/java/org/kaaproject/kaa/client/channel/impl/channels/CoapChannel.java

+    //        if (channelState != State.OPENED) {
+    //            LOG.info("Can't sync. Channel [{}] is waiting for CONNACK message + KAASYNC message", getId());
+    //            return;
+    //        }


Commented out code (see my comment above)

rasendubi · 2016-12-08T01:04:16Z

...ent-java-core/src/main/java/org/kaaproject/kaa/client/channel/impl/channels/CoapChannel.java

+    //        if (currentServer == null || socket == null) {
+    //            LOG.warn("Can't sync. Server is {}, socket is \"{}\"", currentServer, socket);
+    //            return;
+    //        }


commented out code (see my comment above)

rasendubi · 2016-12-08T01:22:14Z

...transport/src/main/java/org/kaaproject/kaa/server/transports/coap/transport/CoapHandler.java

+ * Date: 10/22/16
+ * Time: 3:36 PM
+ * To change this template use File | Settings | File Templates.
+ */


See my comment above on auto-generated headers.

rasendubi · 2016-12-08T01:22:42Z

...ansport/src/main/java/org/kaaproject/kaa/server/transports/coap/transport/CoapTransport.java

+package org.kaaproject.kaa.server.transports.coap.transport;
+
+
+//import org.kaaproject.kaa.server.transport.;


Commented out code.

rasendubi · 2016-12-08T01:23:05Z

...ansport/src/main/java/org/kaaproject/kaa/server/transports/coap/transport/CoapTransport.java

+            .getCommonProperties().getProperty(PUBLIC_INTERFACE_PROP_NAME, LOCALHOST)));
+
+
+    //configuration.getBindInterface(), configuration.getBindPort()


Commented out code.

rasendubi · 2016-12-08T01:23:08Z

...ansport/src/main/java/org/kaaproject/kaa/server/transports/coap/transport/CoapTransport.java

+      // create server
+      server = new CoapHandler(configuration.getBindPort());
+      // add endpoints on all IP addresses
+      //server.addEndpoints();


Commented out code.

rasendubi · 2016-12-08T01:23:54Z

server/transports/pom.xml

@@ -36,5 +36,6 @@
    <modules>
        <module>http</module>
        <module>tcp</module>
+          <module>coap</module>


Indentation level needs to be adjusted.

elysoly · 2016-12-08T09:32:54Z

Hi, Alexey.
Thanks for your kind response. I considered your comments and applied necessary changes. I've pushed the result already.

rasendubi · 2016-12-08T12:09:12Z

@kaa-leeroy test this please

rasendubi · 2016-12-13T14:31:51Z

@kaa-leeroy test this please

rasendubi · 2016-12-14T15:08:53Z

KAA-1640 has been fixed and the current Jenkins failure is caused by the changes in the PR.

@elysoly could you please look at Jenkins logs to see what's wrong?

elysoly · 2016-12-15T09:23:34Z

Hi Alexye ,
Based on Transport provisioning part of kaa document for creating custom transport, I've added some config files to /etc/kaa-node/conf/ on my computer that specifies bind port and public port for coap transport. (files are attached and port numbers are 5683 & 5684). I think loss of these files caused failure. I don't know how can I attach them to my pushed project and also if these port numbers are available for you or not. @rasendubi
http://docs.kaaproject.org/display/KAA/Creating+custom+transport#Creatingcustomtransport-Transportprovisioning
config files.tar.gz

akokhanovskyi · 2016-12-20T11:08:38Z

I've created KAA-1654 for this implementation.

elysoly · 2016-12-20T18:11:52Z

Thank you guys , Should I close this PR? Is everything alright?

akokhanovskyi · 2016-12-21T09:16:27Z

@elysoly Hi! Please don't delete the PR: we have planned in a more in-depth code and architecture review into the current sprint. We will come back to you soon, likely with more suggestions on improvements, etc.

Thanks for your patience while we review your PR.

odovhai · 2017-02-10T19:41:47Z

@kaa-leeroy test this please

Slash32 · 2017-02-13T15:06:07Z

@kaa-leeroy test this please

odovhai · 2017-02-17T15:23:39Z

...ent-java-core/src/main/java/org/kaaproject/kaa/client/channel/impl/channels/CoapChannel.java

+  }
+
+  /**
+   *


Here we need some more java-docs with explanation. It would be better if all comments inside this method are moved to the java-doc .

odovhai

Overall the code is good. There are only some minor issues related to additional logs, java-docs and release versions of external libraries should be fixed.

However we have some failed tests on Jenkins that needs to be fixed as well. I believe there is some general problems with the tests, because main errors are: NPE, org.springframework.beans.factory.BeanCreationException and org.hibernate.service.UnknownServiceException.

The list of failed tests:

org.kaaproject.kaa.server.bootstrap.service.transport.BootstrapTransportServiceTest.messageHandlerProcessTest
org.kaaproject.kaa.server.control.ControlServerApplicationEventMapIT.testCreateApplicationEventFamilyMap
org.kaaproject.kaa.server.control.ControlServerApplicationEventMapIT.testGetVacantEventClassFamiliesByApplicationToken
org.kaaproject.kaa.server.control.ControlServerApplicationEventMapIT.testGetEventClassFamiliesByApplicationToken
org.kaaproject.kaa.server.control.ControlServerApplicationEventMapIT.testGetApplicationEventFamilyMap
org.kaaproject.kaa.server.control.ControlServerApplicationEventMapIT.testUpdateApplicationEventFamilyMap
org.kaaproject.kaa.server.control.ControlServerApplicationEventMapIT.testGetApplicationEventFamilyMapsByApplicationToken
org.kaaproject.kaa.server.control.ControlServerApplicationEventMapIT.org.kaaproject.kaa.server.control.ControlServerApplicationEventMapIT
org.kaaproject.kaa.server.control.ControlServerApplicationIT.org.kaaproject.kaa.server.control.ControlServerApplicationIT
org.kaaproject.kaa.server.control.ControlServerApplicationIT.org.kaaproject.kaa.server.control.ControlServerApplicationIT
org.kaaproject.kaa.server.control.ControlServerCTLSchemaIT.org.kaaproject.kaa.server.control.ControlServerCTLSchemaIT
org.kaaproject.kaa.server.control.ControlServerCTLSchemaIT.org.kaaproject.kaa.server.control.ControlServerCTLSchemaIT
org.kaaproject.kaa.server.control.ControlServerConfigurationIT.testGetConfigurationRecordBody
org.kaaproject.kaa.server.control.ControlServerConfigurationIT.testUpdateConfiguration
org.kaaproject.kaa.server.control.ControlServerConfigurationIT.testGetConfigurationRecord
org.kaaproject.kaa.server.control.ControlServerConfigurationIT.testGetConfigurationRecordsByEndpointGroupId
org.kaaproject.kaa.server.control.ControlServerConfigurationIT.testGetVacantSchemasByEndpointGroupId
org.kaaproject.kaa.server.control.ControlServerConfigurationIT.testActivateConfiguration
org.kaaproject.kaa.server.control.ControlServerConfigurationIT.testDeactivateConfiguration
org.kaaproject.kaa.server.control.ControlServerConfigurationIT.testDeleteConfigurationRecord
org.kaaproject.kaa.server.control.ControlServerConfigurationIT.testCreateConfiguration
org.kaaproject.kaa.server.control.ControlServerConfigurationIT.org.kaaproject.kaa.server.control.ControlServerConfigurationIT
org.kaaproject.kaa.server.control.ControlServerConfigurationSchemaIT.org.kaaproject.kaa.server.control.ControlServerConfigurationSchemaIT
org.kaaproject.kaa.server.control.ControlServerConfigurationSchemaIT.org.kaaproject.kaa.server.control.ControlServerConfigurationSchemaIT
org.kaaproject.kaa.server.control.ControlServerEndpointGroupIT.testGetEndpointGroupsByApplicationToken
org.kaaproject.kaa.server.control.ControlServerEndpointGroupIT.testCreateEndpointGroup
org.kaaproject.kaa.server.control.ControlServerEndpointGroupIT.testGetEndpointGroup
org.kaaproject.kaa.server.control.ControlServerEndpointGroupIT.testDeleteEndpointGroup
org.kaaproject.kaa.server.control.ControlServerEndpointGroupIT.org.kaaproject.kaa.server.control.ControlServerEndpointGroupIT
org.kaaproject.kaa.server.control.ControlServerEventClassFamilyIT.org.kaaproject.kaa.server.control.ControlServerEventClassFamilyIT
org.kaaproject.kaa.server.control.ControlServerEventClassFamilyIT.org.kaaproject.kaa.server.control.ControlServerEventClassFamilyIT
org.kaaproject.kaa.server.control.ControlServerLogAppenderIT.org.kaaproject.kaa.server.control.ControlServerLogAppenderIT
org.kaaproject.kaa.server.control.ControlServerLogAppenderIT.org.kaaproject.kaa.server.control.ControlServerLogAppenderIT
org.kaaproject.kaa.server.control.ControlServerLogSchemaIT.getLogSchemaByApplicationTokenAndVersionTest
org.kaaproject.kaa.server.control.ControlServerLogSchemaIT.getLogSchemasByIdTest
org.kaaproject.kaa.server.control.ControlServerLogSchemaIT.getLogSchemaVersionsByApplicationTokenTest
org.kaaproject.kaa.server.control.ControlServerLogSchemaIT.getLogSchemasByApplicationTokenTest
org.kaaproject.kaa.server.control.ControlServerLogSchemaIT.org.kaaproject.kaa.server.control.ControlServerLogSchemaIT
org.kaaproject.kaa.server.control.ControlServerNotificationIT.org.kaaproject.kaa.server.control.ControlServerNotificationIT
org.kaaproject.kaa.server.control.ControlServerNotificationIT.org.kaaproject.kaa.server.control.ControlServerNotificationIT
org.kaaproject.kaa.server.control.ControlServerNotificationSchemaIT.testGetNotificationSchemasByAppToken
org.kaaproject.kaa.server.control.ControlServerNotificationSchemaIT.testGetNotificationSchemaVersionsByAppToken
org.kaaproject.kaa.server.control.ControlServerNotificationSchemaIT.testGetNotificationSchema
org.kaaproject.kaa.server.control.ControlServerNotificationSchemaIT.testGetUserNotificationSchemasByAppToken
org.kaaproject.kaa.server.control.ControlServerNotificationSchemaIT.testCreateNotificationSchema
org.kaaproject.kaa.server.control.ControlServerNotificationSchemaIT.org.kaaproject.kaa.server.control.ControlServerNotificationSchemaIT
org.kaaproject.kaa.server.control.ControlServerProfileFilterIT.testActivateProfileFilter
org.kaaproject.kaa.server.control.ControlServerProfileFilterIT.testDeactivateProfileFilter
org.kaaproject.kaa.server.control.ControlServerProfileFilterIT.testCreateProfileFilter
org.kaaproject.kaa.server.control.ControlServerProfileFilterIT.testDeleteProfileFilterRecord
org.kaaproject.kaa.server.control.ControlServerProfileFilterIT.testUpdateProfileFilter
org.kaaproject.kaa.server.control.ControlServerProfileFilterIT.testGetVacantSchemasByEndpointGroupId
org.kaaproject.kaa.server.control.ControlServerProfileFilterIT.testGetProfileFilterRecordsByEndpointGroupId
org.kaaproject.kaa.server.control.ControlServerProfileFilterIT.testGetProfileFilterRecord
org.kaaproject.kaa.server.control.ControlServerProfileFilterIT.org.kaaproject.kaa.server.control.ControlServerProfileFilterIT
org.kaaproject.kaa.server.control.ControlServerProfileSchemaIT.testGetProfileSchemasByApplicationToken
org.kaaproject.kaa.server.control.ControlServerProfileSchemaIT.testGetProfileSchemaVersionsByApplicationToken
org.kaaproject.kaa.server.control.ControlServerProfileSchemaIT.testCreateProfileSchema
org.kaaproject.kaa.server.control.ControlServerProfileSchemaIT.testGetProfileSchema
org.kaaproject.kaa.server.control.ControlServerProfileSchemaIT.testUpdateProfileSchema
org.kaaproject.kaa.server.control.ControlServerProfileSchemaIT.org.kaaproject.kaa.server.control.ControlServerProfileSchemaIT
org.kaaproject.kaa.server.control.ControlServerRecordLibraryIT.org.kaaproject.kaa.server.control.ControlServerRecordLibraryIT
org.kaaproject.kaa.server.control.ControlServerRecordLibraryIT.org.kaaproject.kaa.server.control.ControlServerRecordLibraryIT
org.kaaproject.kaa.server.control.ControlServerSdkIT.testGenerateCSdk
org.kaaproject.kaa.server.control.ControlServerSdkIT.testGenerateJavaSdkWithInvalidProfileSchema
org.kaaproject.kaa.server.control.ControlServerSdkIT.testGenerateJavaSdk
org.kaaproject.kaa.server.control.ControlServerSdkIT.testGenerateCppSdkWithEventSupport
org.kaaproject.kaa.server.control.ControlServerSdkIT.testGenerateCSdkWithEventSupport
org.kaaproject.kaa.server.control.ControlServerSdkIT.testGenerateJavaSdkWithEventSupport
org.kaaproject.kaa.server.control.ControlServerSdkIT.testGenerateJavaSdkWithInvalidApplication
org.kaaproject.kaa.server.control.ControlServerSdkIT.testGenerateCppSdk
org.kaaproject.kaa.server.control.ControlServerSdkIT.testGenerateAndroidSdkWithEventSupport
org.kaaproject.kaa.server.control.ControlServerSdkIT.testGenerateJavaSdkWithInvalidNotificationSchema
org.kaaproject.kaa.server.control.ControlServerSdkIT.testGenerateJavaSdkWithInvalidConfigurationSchema
org.kaaproject.kaa.server.control.ControlServerSdkIT.org.kaaproject.kaa.server.control.ControlServerSdkIT
org.kaaproject.kaa.server.control.ControlServerTenantIT.testCreateTenant
org.kaaproject.kaa.server.control.ControlServerTenantIT.testGetTenants
org.kaaproject.kaa.server.control.ControlServerTenantIT.testUpdateTenant
org.kaaproject.kaa.server.control.ControlServerTenantIT.testGetTenant
org.kaaproject.kaa.server.control.ControlServerTenantIT.org.kaaproject.kaa.server.control.ControlServerTenantIT
org.kaaproject.kaa.server.control.ControlServerTopicIT.org.kaaproject.kaa.server.control.ControlServerTopicIT
org.kaaproject.kaa.server.control.ControlServerTopicIT.org.kaaproject.kaa.server.control.ControlServerTopicIT
org.kaaproject.kaa.server.control.ControlServerUserIT.org.kaaproject.kaa.server.control.ControlServerUserIT
org.kaaproject.kaa.server.control.ControlServerUserIT.org.kaaproject.kaa.server.control.ControlServerUserIT
org.kaaproject.kaa.server.node.KaaNodeServerLauncherIT.testStartKaaNodeServerApplication

Also we would like to have a small documentation with some basic examples (like Data Collection Demo) and with simple tests.

odovhai · 2017-02-17T15:28:20Z

client/client-multi/client-java-core/pom.xml

+        <dependency>
+            <groupId>org.eclipse.californium</groupId>
+            <artifactId>californium-core</artifactId>
+            <version>1.1.0-SNAPSHOT</version>


We should avoid snapshot versions of external libraries.
Please use one of the release versions.

Californium version changed to 2.0.0-M2 .

odovhai · 2017-02-17T15:31:36Z

server/transports/coap/pom.xml

+
+    <properties>
+        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+        <main.dir>${basedir}/../../..</main.dir>


it would be better to use absolute path here, because the structure can be changed.

Relative path changed into absolute one.

odovhai · 2017-02-17T15:32:37Z

server/transports/coap/transport/pom.xml

+
+    <properties>
+        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+        <main.dir>${basedir}/../../../..</main.dir>


Needs to be an absolute path

Changes applied. Relative path changed into absolute one.

odovhai · 2017-02-17T15:33:58Z

server/transports/coap/transport/pom.xml

+
+        <dependency>
+            <groupId>org.eclipse.californium</groupId>
+            <artifactId>californium-core</artifactId>


We need to have a release version. Also if it's used in several places it would be better to extract a property for it.

Californium version changed to 2.0.0-M2 .

odovhai · 2017-02-17T15:38:52Z

...transport/src/main/java/org/kaaproject/kaa/server/transports/coap/transport/CoapHandler.java

+  /*
+   * Definition of the Hello-World Resource
+   */
+  class HelloWorldResource extends CoapResource {


We need some logs in each method to inform it's handling.

Add some logs info in each method.

odovhai · 2017-02-17T15:39:52Z

...ansport/src/main/java/org/kaaproject/kaa/server/transports/coap/transport/CoapTransport.java

+   * Initialize a transport instance with a particular configuration and
+   * common transport properties that are accessible via the context. The configuration is an Avro
+   * object. The serializaion/deserialization is done using the schema specified in
+   * {@link KaaTransportConfig}.


needs to have full name with package: @link org.kaaproject.kaa.server.transport.KaaTransportConfig

Done. I've pushed the changes.

odovhai · 2017-02-17T15:42:24Z

...ansport/src/main/java/org/kaaproject/kaa/server/transports/coap/transport/CoapTransport.java

+   */
+  @Override
+  protected int getMinSupportedVersion() {
+    // TODO Auto-generated method stub


We need to have some logs for each unfinished method to indicate that it returns always constant values.

Add SUPPORTED_VERSION as a constant for return.

add full name with package @link

Californium version changed to 2.0.0-M2 .

elysoly · 2017-02-19T13:05:49Z

Dear @odovhai
Based on Transport provisioning part of kaa document for creating custom transport, I've added some config files to /etc/kaa-node/conf/ on my computer that specifies bind port and public port for coap transport. (files are attached and port numbers are 5683 & 5684). I think loss of these files caused failure. I don't know how can I attach them to my pushed project and also if these port numbers are available for you or not but I've faced org.springframework.beans.factory.BeanCreationException and after long time debugging , I found out that problem was about port conflict on my laptop.
hope my experience be helpful.

http://docs.kaaproject.org/display/KAA/Creating+custom+transport#Creatingcustomtransport-Transportprovisioning
config files.tar.gz

odovhai · 2017-02-28T18:20:36Z

@elysoly
Thank's a lot, I've added those files to kaa/server/node/src/main/resources/ and it has fixed issues with integration tests. I've also created a separate PR for it.
The only one thing we need to have some simple examples of using new functionality. Would you be so king to provide us some of them so that we could make a completely described integration and further improvements? :)

elysoly · 2017-03-01T18:17:29Z

Dear @odovhai ,
It would be my pleasure to be of any help. I've attached my simple kaa application (in client-side) that uses coap channel to send simple messages to server. In my server-side version, I added lines of code in /server/transports/coap/transport/.../CoapHandler.java as an implementation for handlePOST method. In other words, I didn't use kaa notification to test; but I've checked that transmitted messages be carried over coap protocol.
I hope these files be helpful but let me know if I misunderstood you or can make any further help.

Simple_use_of_coap.tar.gz

odovhai · 2017-03-07T17:16:39Z

Dear @elysoly ,
We very appreciate your contribution to Kaa Project and to the Community. Based on your example we created a Simple Demo application. This PR will be merged soon and we put on the agenda some discussions about CoapHandler implementation and developments of further Demo Apps related to CoAP transporting.
There is a chance we can ask you about some other details related to the feature, so let's keep in touch :)

Best Regards,
Kaa Project Team

elysoly · 2017-03-11T15:12:35Z

Dear @odovhai
It's my great honor to be joining Kaa Community as a contributor. Thank you for your guide and help.
I'll stay in touch for any further information you might require ;)

MehrAmoon · 2018-12-15T13:29:30Z

Dear @elysoly ,
i work on kaa coap protocol for my theses too , may you help and can i use ur researches for my theses ?!?!?

elysoly · 2018-12-21T20:32:14Z

Dear @elysoly ,
i work on kaa coap protocol for my theses too , may you help and can i use ur researches for my theses ?!?!?

Hi,
Yes sure, my thesis is written in Persian, could it be useful for you?

MehrAmoon · 2018-12-30T08:33:59Z

Dear @elysoly ,
i work on kaa coap protocol for my theses too , may you help and can i use ur researches for my theses ?!?!?

Hi,
Yes sure, my thesis is written in Persian, could it be useful for you?

yes, Im Persian too. could you plz email it ?!?! mine is [email protected]

elysoly added 4 commits December 4, 2016 13:52

CoAP client channel and its protocl ID constants were added.

09f3fc0

Californium CoAP repository was added.

5ee7a3e

coap transport was added to kaa transports.

100484c

coap related jar files was added to pom depenceies.

1924084

rasendubi reviewed Dec 8, 2016

View reviewed changes

Some changes, based on code style, applied.

cd6bbaf

akokhanovskyi changed the title ~~Add CoAP transport to Kaa~~ KAA-1654: Add CoAP transport to Kaa Dec 20, 2016

odovhai mentioned this pull request Feb 10, 2017

EVA-105: DO NOT MERGE #1484

Closed

odovhai reviewed Feb 17, 2017

View reviewed changes

odovhai suggested changes Feb 17, 2017

View reviewed changes

elysoly added 5 commits February 19, 2017 15:02

Add some logs in each method to inform it's handling.

575568f

Add Version number constant.

ef3fb84

add full name with package @link

Relative path changed into absolute one.

09c2bcd

Californium version changed to 2.0.0-M2 .

Relative path changed into absolute one.

1fe8a12

Californium version changed to 2.0.0-M2.

64214d4

odovhai mentioned this pull request Feb 28, 2017

EVA-105: Fixes for PR#1361 (CoAP transport) #1493

Open

		@@ -0,0 +1,265 @@
		package org.kaaproject.kaa.client.channel.impl.channels;

		package org.kaaproject.kaa.server.transports.coap.transport;


		//import org.kaaproject.kaa.server.transport.;

		.getCommonProperties().getProperty(PUBLIC_INTERFACE_PROP_NAME, LOCALHOST)));


		//configuration.getBindInterface(), configuration.getBindPort()

+                }
+                /**
+                 *

KAA-1654: Add CoAP transport to Kaa #1361

Are you sure you want to change the base?

KAA-1654: Add CoAP transport to Kaa #1361

Conversation

elysoly commented Dec 4, 2016

kaa-leeroy commented Dec 4, 2016

Oldnickus commented Dec 5, 2016

rasendubi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rasendubi Dec 8, 2016 • edited Loading

Choose a reason for hiding this comment

elysoly commented Dec 8, 2016

rasendubi commented Dec 8, 2016

rasendubi commented Dec 13, 2016

rasendubi commented Dec 14, 2016

elysoly commented Dec 15, 2016 • edited Loading

akokhanovskyi commented Dec 20, 2016 • edited Loading

elysoly commented Dec 20, 2016

akokhanovskyi commented Dec 21, 2016

odovhai commented Feb 10, 2017

Slash32 commented Feb 13, 2017

odovhai Feb 17, 2017 • edited Loading

Choose a reason for hiding this comment

odovhai left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elysoly commented Feb 19, 2017

odovhai commented Feb 28, 2017 • edited Loading

elysoly commented Mar 1, 2017 • edited Loading

odovhai commented Mar 7, 2017

elysoly commented Mar 11, 2017

MehrAmoon commented Dec 15, 2018

elysoly commented Dec 21, 2018

MehrAmoon commented Dec 30, 2018

rasendubi Dec 8, 2016 •

edited

Loading

elysoly commented Dec 15, 2016 •

edited

Loading

akokhanovskyi commented Dec 20, 2016 •

edited

Loading

odovhai Feb 17, 2017 •

edited

Loading

odovhai left a comment •

edited

Loading

odovhai commented Feb 28, 2017 •

edited

Loading

elysoly commented Mar 1, 2017 •

edited

Loading