Add PodUID to the OVSDB #311
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
kubevirt-bot
added
dco-signoff: no
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jiayoukun The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
needs-ok-to-test
|
Hi @jiayoukun. Thanks for your PR. I'm waiting for a k8snetworkplumbingwg member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
fix #309 |
| OvnPort cnitypes.UnmarshallableString `json:"ovnPort,omitempty"` | ||
| MAC cnitypes.UnmarshallableString `json:"mac,omitempty"` | ||
| OvnPort cnitypes.UnmarshallableString `json:"ovnPort,omitempty"` | ||
| K8S_POD_UID cnitypes.UnmarshallableString |
There was a problem hiding this comment.
there is no assurance runtime will provide this value (altohugh for k8s we do get this information passed down by the runtime)
so in case this arg is not provided should we store an empty value ? or just avoid adding this key to external-ids ?
.idea/.gitignore
Outdated
There was a problem hiding this comment.
Can you remove .idea folder from the commit?
|
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits. 📝 Please follow instructions in the contributing guide to update your commits with the DCO Full details of the Developer Certificate of Origin can be found at developercertificate.org. The list of commits missing DCO signoff:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
CC @SchSeba |
|
@SchSeba Can you confirm the code for me? |
By adding the UID of a Pod to the external_ids field of the corresponding veth interface in the OVSDB, it becomes convenient for the Pod object to query the OVSDB using the UID to find the vethName of the Pod on the host machine, and then deliver OVS flow tables accordingly. Currently, the host machine's veth interface in the OVSDB only stores the Netns field, which is useful, but for Pod objects, their netns is not publicly accessible.