Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to specify vlan_mode in the network configuration #261

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

daghaian
Copy link

@daghaian daghaian commented Jan 20, 2023

What this PR does / why we need it:

Adds a needed ability for specifying VLAN mode to be applied to the attached port instead of defaulting to trunk/access. This enables usage for cases in which the port should operate under one of the alternative VLAN modes: native-untagged, native-tagged, or dot1q-tunnel. In addition, the existing logic for when tags/trunks were applied to the created port was changed to allow for both to be applied to a port when used in conjunction with an access mode such as native-untagged. Please see https://man7.org/linux/man-pages/man5/ovs-vswitchd.conf.db.5.html for any additional clarification.

Special notes for your reviewer:
N/A

Release note:

Added the ability to set `vlan_mode` via a new `vlan_mode` field in the Network Configuration

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 20, 2023
@kubevirt-bot
Copy link
Collaborator

Hi @daghaian. Thanks for your PR.

I'm waiting for a k8snetworkplumbingwg member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 20, 2023
@daghaian
Copy link
Author

/assign @phoracek

@daghaian
Copy link
Author

Bumping this issue to see if someone can take a look. Thanks!

@phoracek
Copy link
Member

phoracek commented Mar 3, 2023

/retest

@kubevirt-bot
Copy link
Collaborator

@daghaian: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-e2e-ovs-cni c885d62 link true /test pull-e2e-ovs-cni

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fails the linter check

@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: daghaian
Once this PR has been reviewed and has the lgtm label, please assign alonakaplan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 2, 2024
@kubevirt-bot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mw-0
Copy link

mw-0 commented Jul 22, 2024

I could do with these changes. Has it been abandoned? @phoracek Was it just the linter change that was the problem?

@phoracek
Copy link
Member

@mw-0 I have not reviewed this in depth yet, but it looks conceptually ok to me. So if you push a new rebased PR, with linter resolved and tests passing, I'm happy to review it and help get it merged.

@daghaian
Copy link
Author

I'm happy to rebase the PR when I have a moment. We've been running our own modified version with this change for a while now haha. Glad to hear it has a use for people :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants