Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn and suppress duplicate registry mirror endpoints #9697

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

brandond
Copy link
Member

@brandond brandond commented Mar 7, 2024

Proposed Changes

Warn and suppress duplicate registry mirror endpoints

Types of Changes

bugfix

Verification

See linked issue and test

Testing

yes

Linked Issues

User-Facing Change

K3s will now warn and suppress duplicate entries in the mirror endpoint list for a registry. Containerd does not support listing the same endpoint multiple times as a mirror for a single upstream registry.

Further Comments

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 42.82%. Comparing base (1c8be1d) to head (bbe2927).
Report is 1 commits behind head on master.

Files Patch % Lines
pkg/agent/containerd/config.go 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9697      +/-   ##
==========================================
- Coverage   50.69%   42.82%   -7.87%     
==========================================
  Files         154      154              
  Lines       13595    13599       +4     
==========================================
- Hits         6892     5824    -1068     
- Misses       5361     6670    +1309     
+ Partials     1342     1105     -237     
Flag Coverage Δ
e2etests 35.25% <0.00%> (-9.45%) ⬇️
inttests 34.87% <0.00%> (-4.50%) ⬇️
unittests 16.18% <75.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brandond brandond merged commit fe2ca9e into k3s-io:master Mar 8, 2024
21 checks passed
@brandond brandond deleted the fix-duplicate-endpoint branch June 6, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants