Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.31] add node-internal-dns/node-external-dns address pass-through support … #11464

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

brandond
Copy link
Member

Proposed Changes

Types of Changes

enhancement

Verification

k3s server --node-external-dns node.example.com

now yields:

image

As you can see it correctly sets the ExternalDNS address.

Testing

Linked Issues

User-Facing Change

Further Comments

…3s-io#10852)

* add --node-internal-dns and --node-external-dns

Signed-off-by: Arne Winter <[email protected]>
Co-authored-by: Brad Davidson <[email protected]>
(cherry picked from commit c4c11e5)
Signed-off-by: Brad Davidson <[email protected]>
@brandond brandond requested a review from a team as a code owner December 11, 2024 19:08
@brandond brandond changed the title add node-internal-dns/node-external-dns address pass-through support … [release-1.31] add node-internal-dns/node-external-dns address pass-through support … Dec 11, 2024
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 20 lines in your changes missing coverage. Please review.

Project coverage is 43.30%. Comparing base (b62f474) to head (3488239).
Report is 1 commits behind head on release-1.31.

Files with missing lines Patch % Lines
pkg/cloudprovider/instances.go 0.00% 6 Missing and 2 partials ⚠️
pkg/agent/config/config.go 50.00% 4 Missing and 2 partials ⚠️
pkg/agent/run.go 40.00% 2 Missing and 4 partials ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.31   #11464      +/-   ##
================================================
- Coverage         47.64%   43.30%   -4.34%     
================================================
  Files               181      181              
  Lines             18752    18784      +32     
================================================
- Hits               8934     8135     -799     
- Misses             8486     9449     +963     
+ Partials           1332     1200     -132     
Flag Coverage Δ
e2etests 35.40% <37.50%> (-7.57%) ⬇️
inttests 34.79% <37.50%> (+16.06%) ⬆️
unittests 14.27% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brandond brandond merged commit eff8f18 into k3s-io:release-1.31 Dec 12, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants