Convert legacy docker tests from bash to golang #11357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
dereknola
force-pushed
the
k3s_docker_compose
branch
from
f171bd5 to
85373fd
Compare
Prebuild K3s Go Tests Strip go test binaries to reduce size Crank native GHA compression Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
dereknola
force-pushed
the
k3s_docker_compose
branch
from
85373fd to
66340b3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11357 +/- ##
==========================================
- Coverage 47.18% 38.05% -9.14%
==========================================
Files 179 162 -17
Lines 18600 18010 -590
==========================================
- Hits 8776 6853 -1923
- Misses 8469 9959 +1490
+ Partials 1355 1198 -157
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
brandond
requested changes
Nov 25, 2024
Comment on lines
+391
to
+392
| // TODO the below functions are duplicated in the integration test utils. Consider combining into commmon package | ||
| // DeploymentsReady checks if the provided list of deployments are ready, otherwise returns an error |
There was a problem hiding this comment.
👍🏻 on combining these as soon as possible.
We also have another copy in rke2. Maybe we need a common repo for the test framework. Maybe there already is one from k8s and we should be using that instead.
Signed-off-by: Derek Nola <[email protected]>
brandond
previously approved these changes
Nov 25, 2024
manuelbuil
previously approved these changes
Nov 26, 2024
| spec: | ||
| containers: | ||
| - name: stargz-snapshot-test | ||
| image: "ghcr.io/stargz-containers/k3s-test-ubuntu:20.04-esgz" |
There was a problem hiding this comment.
ubuntu:20.04 oh no, so old
There was a problem hiding this comment.
Yeah there is future work to potentially:
- Update this image
- No longer test this functionality, IDK how many people are still using this.
- Move to a newer test image that supports the same thing from someone else.
Signed-off-by: Derek Nola <[email protected]>
manuelbuil
approved these changes
Nov 26, 2024
|
Yeah I'm gonna squash |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The current docker tests use a complex series of bash function hooks to construct k3s cluster out of docker containers, using the
rancher/k3simage we publish. These tests are difficult to read, difficult to write, and do not match the ginkgo/gomega centric BDD testing frameworks we have constructed for integration and E2E tests.Proposed Changes
compattest is nowskewtest, as we are testing the skew policy of K8s.Note: For now this is going to exist alongside the legacy docker tests. More work needs to be done to ensure things like log output and failures are handled effectively.
Types of Changes
Major CI change, Testing
Verification
https://github.com/k3s-io/k3s/actions/runs/12019291772
Testing
Its all new tests!
Linked Issues
#11419
User-Facing Change
Further Comments