Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI step to create a issue from a PR #10277

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vitorsavian
Copy link
Member

@vitorsavian vitorsavian commented Jun 3, 2024

Proposed Changes

  • New CI step for new PRs

This new CI step will create a issue when someone that is not a public member of k3s.

Types of Changes

  • Feature

Verification

  • See if you are public in the k3s organization and change to private if you are public

  • Create a PR without a link to a GitHub issue in the body of the PR

  • Follow to checks and then see the issue created that will be posted in the comments

Testing

Linked Issues

User-Facing Change


Further Comments

  • The team members who write PRs will need to be public on the k3s organization

@vitorsavian vitorsavian requested a review from a team as a code owner June 3, 2024 18:49
@vitorsavian vitorsavian force-pushed the ci-create-issue-from-pr branch from 8bd2a29 to 2f08c58 Compare July 1, 2024 17:52
@vitorsavian vitorsavian marked this pull request as draft October 2, 2024 16:49
@vitorsavian vitorsavian marked this pull request as ready for review October 18, 2024 14:42
@dereknola
Copy link
Member

Does this handle the existence of existing linked issues (i.e. I already have a linked issue in the PR body when i open the PR)?

Copy link
Member

@dereknola dereknola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiding the logic inside a external action is not super helpful, we should move this within the k3s-org.

@@ -0,0 +1,24 @@
name: Create issue from PR
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: Create issue from PR
name: Create linked issues for PRs without one

.github/workflows/create-issue-from-pr.yaml Outdated Show resolved Hide resolved
@vitorsavian
Copy link
Member Author

Does this handle the existence of existing linked issues (i.e. I already have a linked issue in the PR body when i open the PR)?

It does not, I remember Caroline saying something about using this to make we track the PRs using the issues

but I believe it can be done, the steps takes then entire body of the PR

@vitorsavian
Copy link
Member Author

Hiding the logic inside a external action is not super helpful, we should move this within the k3s-org.

That is a thing that I want to speak with the team, is it ok to create a new repo to add the js logic?

@vitorsavian vitorsavian marked this pull request as draft October 21, 2024 15:06
@vitorsavian vitorsavian force-pushed the ci-create-issue-from-pr branch 2 times, most recently from a195063 to 9e1cb47 Compare October 22, 2024 17:40
@vitorsavian vitorsavian force-pushed the ci-create-issue-from-pr branch from 9e1cb47 to 4dd7880 Compare October 22, 2024 17:42
@vitorsavian vitorsavian marked this pull request as ready for review October 22, 2024 17:42
@vitorsavian vitorsavian requested a review from dereknola October 22, 2024 17:42
@vitorsavian
Copy link
Member Author

@dereknola I changed the action to entire shell script within the actions, I think it is better instead of having to build Js inside the .github/actions

@vitorsavian vitorsavian requested a review from a team October 23, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants