Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

append /run/cluster-api/bootstrap-success.complete #79

Merged
merged 1 commit into from
Dec 6, 2023
Merged

append /run/cluster-api/bootstrap-success.complete #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/cloudinit/controlplane_init.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const (
{{template "files" .WriteFiles}}
runcmd:
{{- template "commands" .PreK3sCommands }}
- 'curl -sfL https://get.k3s.io | INSTALL_K3S_VERSION=%s sh -s - server'
- 'curl -sfL https://get.k3s.io | INSTALL_K3S_VERSION=%s sh -s - server && mkdir -p /run/cluster-api && echo success > /run/cluster-api/bootstrap-success.complete'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is your opinion of just adding this as a separate command rather than chaining it?

I prefer this approach as i find it more readable and easier to debug on failed nodes, but that is just my two cents.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A separate command would be incorrect, please check the comment above.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh i see thanks. hmm we should probably make an issue to just create a bootstrap script like the kubeadm providers.

{{- template "commands" .PostK3sCommands }}
`
)
Expand Down
2 changes: 1 addition & 1 deletion pkg/cloudinit/controlplane_join.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ const (
{{template "files" .WriteFiles}}
runcmd:
{{- template "commands" .PreK3sCommands }}
- 'curl -sfL https://get.k3s.io | INSTALL_K3S_VERSION=%s sh -s - server'
- 'curl -sfL https://get.k3s.io | INSTALL_K3S_VERSION=%s sh -s - server && mkdir -p /run/cluster-api && echo success > /run/cluster-api/bootstrap-success.complete'
{{- template "commands" .PostK3sCommands }}
`
)
Expand Down
2 changes: 1 addition & 1 deletion pkg/cloudinit/worker_join.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ const (
{{template "files" .WriteFiles}}
runcmd:
{{- template "commands" .PreK3sCommands }}
- 'curl -sfL https://get.k3s.io | INSTALL_K3S_VERSION=%s sh -s - agent'
- 'curl -sfL https://get.k3s.io | INSTALL_K3S_VERSION=%s sh -s - agent && mkdir -p /run/cluster-api && echo success > /run/cluster-api/bootstrap-success.complete'
{{- template "commands" .PostK3sCommands }}
`
)
Expand Down
Loading