feat: Support SSA patch for metadata propagation #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nasusoba
changed the title
Signed-off-by: nasusoba <[email protected]> finished implementation Signed-off-by: nasusoba <[email protected]> add test Signed-off-by: nasusoba <[email protected]> fix ssaCache init Signed-off-by: nasusoba <[email protected]> increase control plane replicas for test Signed-off-by: nasusoba <[email protected]> fix typo Signed-off-by: nasusoba <[email protected]> fix typo
mogliang
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports ssa patch for capi k3s. With it, the mutable fields on KThreesControlPlane will be propagated to the underlying machines/infrastructureMachine/kthreesconfigs without rollout. Fixed #134
SSA (Server-Side Apply) is needed so that if a label is deleted in KThreesControlPlane, it will also get cleaned up from the underlying resources.