Fix a bug for etcd removal machine controller [Etcd Proxy] #125
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug found
The cluster cannot be deleted if the user first scale down a cluster, and then delete it. The deletion process got stuck
Why
PreTerminateDeleteHookAnnotationPrefix
setetcd.k3s.cattle.io/remove
to that node, waiting for theetcd.k3s.cattle.io/removed-node-name
to be setetcd.k3s.cattle.io/removed-node-name
annotation, as the whole cluster is down. And it stuck forever, with the machine not deletedFix
Before machine controller remove an etcd member, it will check if the cluster/cp is already under deletion, or if the removed machine is the last node, or if the machine has no noderef. If so, it will skip etcd removal.