feat: Change from upgradeAfter to rolloutAfter in v1beta2 api upgrade #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wikoion
force-pushed
the
wikoion/move-to-rolloutafter
branch
2 times, most recently
from
54a2923
to
3ad2bdf
Compare
Signed-off-by: Richard Draycott <[email protected]>
wikoion
force-pushed
the
wikoion/move-to-rolloutafter
branch
from
3ad2bdf
to
bf01f95
Compare
Signed-off-by: Richard Draycott <[email protected]>
wikoion
force-pushed
the
wikoion/move-to-rolloutafter
branch
from
f3f7f4b
to
056cec8
Compare
Signed-off-by: Richard Draycott <[email protected]>
wikoion
force-pushed
the
wikoion/move-to-rolloutafter
branch
from
d93f45c
to
47ded5b
Compare
|
Have you verified if |
There's some work that would need to be done in cluster-api to enable that. They currently have the types hardcoded for clusterctl alpha rollout, so it will only work with machinedeployments and kubeadmcontrolplanes. I opened an issue here kubernetes-sigs/cluster-api#10621 |
nasusoba
approved these changes
May 17, 2024
mogliang
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes v1beta2 to use rolloutAfter instead of upgradeAfter for parity with the kubeadm controlplane in cluster-api.
Addresses: #115