Feat / Payment recaptcha #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
royschut
force-pushed
the
feat/payment-recaptcha
branch
from
4c6adfc
to
d6a6dfa
Compare
refactor(payment): move recaptche to right side of form
royschut
force-pushed
the
feat/payment-recaptcha
branch
from
d6a6dfa
to
a077f19
Compare
langemike
approved these changes
Nov 1, 2024
|
@royschut is there any need to change the token dynamically (in custom params)? Did you consider making it part of the ini file? |
AntonLantukh
reviewed
Nov 4, 2024
packages/ui-react/src/containers/AccountModal/forms/Checkout.tsx
Outdated
Show resolved
Hide resolved
The convenience of adding it to the app config is mainly for config switching, so for demonstration purposes. Otherwise config demonstration would not be possible for configs with captcha enabled. |
AntonLantukh
approved these changes
Nov 4, 2024
This was referenced Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feat / Payment ReCaptcha
In addition to #630, this PR optionally adds recaptcha validation to Payment endpoint calls.
Recaptcha can be enabled from the Cleeng dashboard. The site token should then be added as a custom parameter to the app-config:
captcha_site_key=<site_id>to have the validator (by Google) added to the DOM.Steps completed:
According to our definition of done, I have completed the following steps: