Fix / missing feedback when submitting coupon #476
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an issue we found during testing. For some reason, there was no feedback when submitting a coupon code. I tried to reproduce this, but the only way I could was to make the
updateOrder
fetch fail. For example, Google Chrome can be put in "Offline" mode using the network tab.Because there was no feedback, I traced the code and remembered (and spotted some TOODs :-)) that the
updateOrder
method was a bit funky.This PR addresses some problems and solves the TODOs:
responseData.errors
to contain Error objects (only strings are expected)Although the generic error shows "Unknown error", we know the reason. But we should solve this problem structurally, not just for the
updateOrder
method.CC: @langemike