feat: encryption service integration to support batch encryption and decryption #5164
+3,927
−1,242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h into add_mtls_keymanager
…nto add_mtls_keymanager
…o add_migration_api
…o add_migration_api
… avoid duplicate code
ArjunKarthik
added
A-infra
dracarys18
requested changes
Jul 2, 2024
…h into add_mtls_keymanager
…nto add_migration_api
…o encryption-api-integration
…o encryption-api-integration
An error occurred while trying to automatically change base from
add_migration_api
to
add_encryption_service
July 8, 2024 09:08
…h into encryption-api-integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Additional Changes
Motivation and Context
PCI compliance requires application to follow some standards where encryption and decryption should not happen within the application as snapshot might have DEK and data together. So separate service should be used for encryption and decryption. In application wherever we are calling encrypt and decrypt it will be replaced by API call to encryption service.
How did you test it?
Local Testing
Checklist
cargo +nightly fmt --allcargo clippy