Enable include-hidden-files for actions/upload-artifact@v4
#245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtpio
changed the title
include-hidden-files to actions/upload-artifact@v4include-hidden-files for actions/upload-artifact@v4
|
I think it is safe to merge as the PR fixes exactly the test that is failing. |
|
Yes, also the motivation for the original upstream change was mostly for security reasons: actions/upload-artifact#598 But in our case we select only one file to be upload (the coverage file). |
|
For reference it also seems to be affecting other repos using this action, for example |
|
This seems to be fixing the upload part. Although the
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like we now need to set this option when uploading coverage, since the default file starts with a leading
.and is likely considered as ignored.https://github.com/actions/upload-artifact/releases/tag/v4.4.0
This would explain why the coverage check started failing on notebook: jupyter/notebook#7456