Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include (potentially nested) pyproject.toml files in the pip hash key #244

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Include (potentially nested) pyproject.toml files in the pip hash key #244

merged 1 commit into from
Sep 6, 2024

Conversation

krassowski
Copy link
Member

Fixes #243

@krassowski krassowski mentioned this pull request Aug 12, 2024
Merged
@krassowski krassowski added the bug Something isn't working label Aug 13, 2024
fcollonval
fcollonval approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @krassowski

@krassowski krassowski merged commit 3ab82c3 into jupyterlab:main Sep 6, 2024
26 of 27 checks passed
@krassowski krassowski deleted the inlcude-pyproject.toml-in-hash-key branch September 6, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcollonval fcollonval fcollonval approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cache key does not account for pyproject.toml files
2 participants
@krassowski @fcollonval