Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weakref to enable gc + setting children with iterable + fix various tooltips #3921

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

Copy link

Binder 👈 Launch a binder notebook on branch fleming79/ipywidgets/weakref

liamb27 and others added 9 commits June 9, 2024 09:16
Example for FloatLogSlider labeled min and max in reverse order; changed it so it is correct.
1. @lumino/messaging ^2.1 should be ^2.0.1
2. @lumino/messaging ^2.1 should be ^2.0.1
3. istanbul-instrumenter-loader is not maintaned for 6 years
…pe of iterable plus a configurable option to omit invalid items (including closed widgets) and log a warning or error.
@fleming79 fleming79 changed the title weakref to enable gc + setting children with iterable + fix loading state via jupyter.widget.control + fix various tooltips weakref to enable gc + setting children with iterable + fix various tooltips Jun 10, 2024
Alan Fleming added 2 commits August 31, 2024 10:25
packages/base/src/widget.ts Outdated Show resolved Hide resolved
@fleming79
Copy link
Author

@vijayi1 Thanks for pointing that out. Attached are files for the latest .

files.zip

@vijayi1
Copy link

vijayi1 commented Sep 10, 2024

@fleming79 , the fix works for me, thanks.
the table below summarizes the behavior with and without the fix for the text, dropdown, checkbox and button widgets.
(note line 3, the behavior was inconsistent across widgets previously. if someone expects nothing to be displayed, with the fix they would have to set the tooltip to an empty string)

image

Alan Fleming added 4 commits September 12, 2024 18:13
…into weakref
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants