-
-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/#602 - Add support for React 19 #665
base: master
Are you sure you want to change the base?
Conversation
|
I am not sure how the CHANGELOG update is handled properly. I assume the PR gets stashed before getting merged so i don't know the merge commit ID to use in the CHANGELOG. So a few questions:
|
I tested the implementation also with React 18 in another repository. AFAIK it's not possible to add another app to this monorepo using React 18 next to the current implementation using React 19. |
Just read the provided documentation - its just there in provided comment that was made by the bot... Click here to learn what changesets are, and how to add one. |
@juliencrn Could this be expedited please? |
Thanks @ondrej-langr. For someone who doesn't know changesets at all like myself https://github.com/juliencrn/usehooks-ts/blob/master/.github/CONTRIBUTING.md doesn't provide much information how to handle it properly in this repository. #665 (comment) complained about a missing changeset but it didn't help me out but made me feel uncertain. So i asked :) According to https://www.npmjs.com/package/@changesets/cli the main purpose of changesets is to
and
and
. So i reverted the version updates i previously added manually and added a changeset via |
@iwan-uschka Indeed! Great job! Just a quick sidenote about the changeset message - remove that Changesets are unique in a way that you dont have to adhere to any maximum characters as far as i know so you can add bigger explanations of your updates. One pull request can have multiple changesets even! (but in that case its better to just make more PRs) |
Thx again @ondrej-langr.
I did exactly that but still got confused because you can find commits like b14db5b using that notation i used or 7ba7e3a with no changeset at all. Anyway, |
This PR adds support for React 19 by fixing TS issues regarding
useRef
(see https://react.dev/blog/2024/04/25/react-19-upgrade-guide#useref-requires-argument).To be able to use React 19 throughout the project i had to update some other dependencies as well.
To be able to use the TypeScript version of this project in VS Code i removed all
typescript
dependencies from allpackage.json
and added one singletypescript
dependency to the rootpackage.json
. I hope this is ok.Before this change, they were two versions of
typescript
:5.4.3
and5.3.3
. Now we have only one version oftypescript
:5.4.3
. To avoid running into warnings likewhen calling
pnpm lint
i had to update@typescript-eslint
to7.18.0
. This required some fixes to add to the codebase.