Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add unit tests on useFetch. #367

Merged
merged 3 commits into from
Jan 19, 2024

Conversation

ashfurrow
Copy link
Contributor

Hello 👋 I've been practicing coding for job interviews and needed to write some tests for my own useFetch. When I was looking around for the best approach, I found this library but the useFetch hook tests were missing. Since I wrote my own, I thought I might as well port them over here.

I hope this helps. I've tried to match existing idioms in the repository, but I'm happy to reformat or tweak these further.

@changeset-bot
Copy link

changeset-bot bot commented Aug 15, 2023

🦋 Changeset detected

Latest commit: dc74b7c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
usehooks-ts Patch
www Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 15, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @juliencrn on Vercel.

@juliencrn first needs to authorize it.

@juliencrn juliencrn added the enhancement Improvements label Jan 19, 2024
Copy link
Owner

@juliencrn juliencrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 Thanks!

I've just update a bit the test names with the it should ... template to enhance the readability and clarity of the test suite

@juliencrn juliencrn merged commit a3588b8 into juliencrn:master Jan 19, 2024
1 check passed
@juliencrn
Copy link
Owner

+1 #423

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants