Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support sessionStorage option for web #824

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

rjs580
Copy link

@rjs580 rjs580 commented Nov 13, 2024

Added the ability to use sessionStorage instead of localStorage through a new option in the WebOptions class. This change involves updating the storage access methods to choose between sessionStorage and localStorage based on the provided options.

Justification for this change:

  1. Scope Control

    • sessionStorage is designed to store data for the duration of a page session. This means that when the user closes the browser tab, the data is automatically cleared, which can be advantageous for sensitive information that should not persist after the session ends.
  2. Security

    • Storing sensitive information such as authentication tokens in sessionStorage can enhance security. It minimizes the risk of leaking sensitive data if another user gains access to the device because the data does not persist between sessions.
  3. Use Case Flexibility

    • By providing the option to choose between localStorage and sessionStorage, developers can tailor data storage strategies based on the specific needs of their application. Long-term storage can use localStorage, whereas temporary, session-based data can use sessionStorage.
  4. Compliance Requirements

    • Some applications need to comply with strict data storage regulations, which may mandate that sensitive information not persist beyond a session. sessionStorage supports adherence to such compliance requirements.

Added the ability to use sessionStorage instead of localStorage through a new option in the WebOptions class. This change involves updating the storage access methods to choose between sessionStorage and localStorage based on the provided options.
@rjs580 rjs580 changed the title Support sessionStorage option for web feat: Support sessionStorage option for web Nov 13, 2024
@rjs580
Copy link
Author

rjs580 commented Dec 3, 2024

Hello @juliansteenbakker,

Could you please review and approve this PR? The changes are crucial for our next update, as they introduce important enhancements to data storage options that support improved security and compliance. Your prompt review would be greatly appreciated.

Thank you

@amrgetment
Copy link

Nice PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants