snap: Add rust to build-packages [2.8 backport] #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* snap: Add rust to build-packages When building the snap on s390x some Python modules need to compile their extensions (rust based), this is not needed on amd64 since pypi has compiled packages available. This change add rustc, cargo and pkg-config to the list of build-packages in the snapcraft.yaml definition. * Migrate gh action actions/upload-artifact@v4 * Migration gh action actions/download-artifact@v4 The backport was adjusted to use build-snap.yml workflow instead of test.yml (cherry picked from commit b8747e0)
freyes
force-pushed
the
2.8-add-rustc
branch
from
e272b97 to
0f9ff96
Compare
The 2.8 branch uses core18 to build the snap on, python 3.10 is not available, python 3.6 is the version available in Ubuntu 18.04 (Xenial)
snapcraft-7.x is the last release with core18 support
freyes
force-pushed
the
2.8-add-rustc
branch
from
badebcc to
60dd304
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building the snap on s390x some Python modules need to compile
their extensions (rust based), this is not needed on amd64 since pypi
has compiled packages available.
This change add rustc, cargo and pkg-config to the list of
build-packages in the snapcraft.yaml definition.
Migrate gh action actions/upload-artifact@v4
Migration gh action actions/download-artifact@v4
The backport was adjusted to use build-snap.yml workflow instead of
test.yml
(cherry picked from commit b8747e0)
Checklist