-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(linux): add device names options #415
Conversation
6a38c6c
to
ce7e4e4
Compare
Note: I haven't tested the functionality by unplugging or replugging devices since I typically only use Linux via Virtual Machines or WSL2, and I don't ever attach the USB keyboard device to the VM directly. But I think it should work. |
I don't see any issues with However, I think there's a problem with
|
Adding 200 ms sleep here no longer throws an error. Line 164 in ce7e4e4
|
Thanks for testing! Added a sleep, though in a different line of code, to be more targeted. A single hard-coded longer sleep feels a little unclean, as opposed to shorter retry-sleeps, but I think in practice it doesn't matter since this only happens when plugging in a new keyboard. |
Implements #376, #378