Only predict into levels that are fit in the model, and issue a warning when they are not available. Also, enable ... to pass arguments to boot::boot()
#53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng when they are not available. Also, enable ... to pass arguments to `boot::boot()`
|
FYI, one downside to this PR is that there will usually be tons of warnings. Some way to manage the warnings so that they only occur once per column per bootstrap would likely be helpful. The fix that occurred to me is a bit more invasive, and it wasn't clear that the benefit was worth the code maintenance (maybe there is a simpler way than the one that occurred to me, though). |
|
Just a note that I have not forgotten about this PR and will review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #52 by setting factor levels to NA when they are not part of the data that are fit in the update. (It should be compatible with PR #51 as it changes code below the model fitting while that PR changes code up to and including the model fitting.)