Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a custom root component tag. #46

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

glaubermagal
Copy link

Added a feature capable of changing the root component tag.

Copy link
Owner

@jstejada jstejada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments inline

package.json Outdated
@@ -1,9 +1,12 @@
{
"name": "react-typist",
"version": "2.0.4",
"version": "2.0.5",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you remove these changes? I'll update the version when I publish a new version separately

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed in my last commit. Thank you

Copy link
Author

@glaubermagal glaubermagal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put back the version to 2.0.4. Thank you for accepting my merge!

package.json Outdated
@@ -1,9 +1,12 @@
{
"name": "react-typist",
"version": "2.0.4",
"version": "2.0.5",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed in my last commit. Thank you

@glaubermagal
Copy link
Author

Hi @jstejada, are my changes ok?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants