Rust: Fixing Dockerfile and Cargo.toml for test cases #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niko-dunixi
force-pushed
the
feature/docker-cargo-caching
branch
from
428efb8
to
9826d67
Compare
|
I didn't realize that there was a requirement for commits to be signed. I've setup GPG and then rebased my branch to resign all the commits before force-pushing to update this PR. |
|
@ucarion would you mind reviewing this change? It seems that there are a few improvements which are blocked by test failures. |
niko-dunixi
force-pushed
the
feature/docker-cargo-caching
branch
6 times, most recently
from
ab608d0
to
f758762
Compare
niko-dunixi
force-pushed
the
feature/docker-cargo-caching
branch
from
f758762
to
cfb134a
Compare
|
@ucarion My apologies for any inconvenience, but I didn't realize when I revoked my older GPG key that it actually unverified my previous commits. I've re-signed them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves issue: #57
Solution
I've pinned the dependencies at a version that works today and sets the tested Rust version to one that is also current.
Extra Credit
I've also added docker buildkit into the mix so the cargo dependencies are shared across each of the test-cases and saves some testing time. I don't know if there is any CI/CD in place already, but if the Docker version running is current this should be non-breaking