Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the JSON Schema Test Suite to version 2.0.0 #714

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update the JSON Schema Test Suite to version 2.0.0 #714

wants to merge 1 commit into from

Conversation

niconoe-
Copy link
Contributor

Replay of the #582

@niconoe- niconoe- mentioned this pull request Feb 19, 2024
Closed
dafeder
dafeder reviewed May 21, 2024
View reviewed changes
Copy link

@dafeder dafeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are new skipped tests, particularly ref.json. Is this because of a bug that needs to be documented?

@DannyvdSluijs
Copy link
Collaborator

From the original PR:

Update the JSON Schema Test Suite to version 2.0.0 to fetch test suites on Draft 06 and Draft 07.
Updated validation on draft 04 since changes have been done on the test suites.

Regarding some discussions on #581 I wanted to have access to the official test-suite for draft 07. This is possible by upgrading the JSON-Schema-Test-Suite in version 2.0.0, on which Draft 04 has been upgraded too.

I required to upgrade some snippet and make evolved some tests to make pass the Draft 04 validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dafeder dafeder dafeder left review comments

Assignees
No one assigned
Labels
draft-06 draft-07
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niconoe- @DannyvdSluijs @dafeder