Invalid string validation #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@snapshotpl thanks for the effort. Sadly the PR was left unanswered for some time due to time constraints for people helping out on this library. In an attempt to revive the project I'm trying to do some triage on the issues and pull requests. Your additional test case seems correct, although the file it has been put in seems a bit unfitting, since there is no tupple of types being tested. It seems that ArraysTest.php would be a more fitting location? Would you be willing to spend the effort in order to get this PR considered ready for merging? |
DannyvdSluijs
force-pushed
the
invalid-string-validation
branch
3 times, most recently
from
612920c
to
fb52ae3
Compare
DannyvdSluijs
approved these changes
May 27, 2024
DannyvdSluijs
force-pushed
the
invalid-string-validation
branch
from
fb52ae3
to
148321c
Compare
DannyvdSluijs
approved these changes
Sep 20, 2024
|
@snapshotpl thanks for your efforts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test case for invalid string type validation. I cannot run this test case locally because missing php 8 support for test