Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codesniffer; fix phpcs errors wrt PSR12 #660

Closed
wants to merge 1 commit into from
Closed

Add codesniffer; fix phpcs errors wrt PSR12 #660

wants to merge 1 commit into from

Conversation

robocoder
Copy link

@robocoder robocoder commented Mar 19, 2021

This PR assumes you bump the PHP requirement to PHP 7.1+.

@DannyvdSluijs
Copy link
Collaborator

Raising to PHP 7.1 should be okay (as per #706 (comment)). However I think it is unexpected to have this "big" change be part of (what looks like) a housekeeping PR.

@robocoder I had tagged you in #659 as well which is now closed by you without a comment. Can we make the assumption you're no longer pursuing any PR's on this project? Meaning #660 and #661 should also be closed?

@robocoder robocoder closed this Feb 12, 2024
@robocoder
Copy link
Author

Yeah, that's to be expected when PRs collect dust for 3 yrs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants