Fix compatability with Django safe_join and Windows (leading "/" on file path) #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onto the user specified save path. The django utility django.utils._os.safe_join is used if the operating system is not windows 'nt'. If the operating sytem is windows 'nt' then the passed name will be checked against a path style specified for the dropbox SDK. AKA the root is kept as '/' and no drive is prefixed
|
@johnvorsten, are you sure that are not needed to add? |
jschneier
reviewed
Sep 9, 2021
| final_path = os.path.join(self.root_path, name).replace('\\', '/') | ||
|
|
||
| # Separator on linux system | ||
| sep = '//' |
There was a problem hiding this comment.
Isn't sep on Linux (Unix) just a single slash (/)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though you pass the upload_to argument which gives a unix-style path (something like /save/path) the django utility makes sure the root of that save path matches the base path for the operating system :(. The dropbox SDK does not like a drive prefixed to the desired save path (AKA C:/path/file.name is not a valid save directory for dropbox).