Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CVN18 ARQC padding method #615

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Fix CVN18 ARQC padding method #615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dcb5ae4
Fix CVN18 ARQC padding method
tilln Sep 12, 2024
6a2927d
Dummy change to trigger rebuild
tilln Sep 13, 2024
6e4cd08
Dummy change to trigger rebuild
tilln Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion jpos/src/main/java/org/jpos/emv/cryptogram/CVN18DataBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,6 @@ public String buildARQCRequest(TLVList data, IssuerApplicationData iad) {

@Override
public PaddingMethod getPaddingMethod() {
return PaddingMethod.ISO9797Method1;
return PaddingMethod.ISO9797Method2;
}
}
3 changes: 0 additions & 3 deletions jpos/src/test/java/org/jpos/emv/cryptogram/CVN10DataBuilderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,9 @@ void testBuildARQCRequest() {
"00000000010000000000000008400000000000084018123101ABCDEF101800000203000000",
builder.buildARQCRequest(data, iad)
);

assertEquals(
"00000000010000000000000008400000000000084018123101ABCDEF101800000203000000000000",
builder.buildARQCRequest_padded(data, iad)
);


}
}
5 changes: 1 addition & 4 deletions jpos/src/test/java/org/jpos/emv/cryptogram/CVN18DataBuilderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,9 @@ void testBuildARQCRequest() {
"00000000010000000000000008400000000000084018123101ABCDEF101800000106011203000000",
builder.buildARQCRequest(data, iad)
);

assertEquals(
"00000000010000000000000008400000000000084018123101ABCDEF101800000106011203000000",
"00000000010000000000000008400000000000084018123101ABCDEF1018000001060112030000008000000000000000",
builder.buildARQCRequest_padded(data, iad)
);


}
}
4 changes: 4 additions & 0 deletions jpos/src/test/java/org/jpos/emv/cryptogram/CVN22DataBuilderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,5 +55,9 @@ void testBuildARQCRequest() {
"00000000010000000000000008400000000000084018123101ABCDEF10180000011F22010300000000000000000000000000000000000000000000000000000000",
builder.buildARQCRequest(data, iad)
);
assertEquals(
"00000000010000000000000008400000000000084018123101ABCDEF10180000011F2201030000000000000000000000000000000000000000000000000000000080000000000000",
builder.buildARQCRequest_padded(data, iad)
);
}
}
1 change: 0 additions & 1 deletion jpos/src/test/java/org/jpos/emv/cryptogram/CVNCPADataBuilderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ void testBuildARQCRequest() {
"0000000100000000000010000840000000108008409807040011111111580034560FA500A03800000000000000000000000F010000000000000000000000000000",
builder.buildARQCRequest(data, iad)
);

assertEquals(
"0000000100000000000010000840000000108008409807040011111111580034560FA500A03800000000000000000000000F01000000000000000000000000000080000000000000",
builder.buildARQCRequest_padded(data, iad)
Expand Down
6 changes: 4 additions & 2 deletions jpos/src/test/java/org/jpos/emv/cryptogram/CVNMCDataBuilderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,10 @@ void buildARPCRequest() {
"000000010000000000001000084000000010800840980704001111111158003456608003220000",
builder.buildARQCRequest(data, iad)
);

assertEquals(
"00000001000000000000100008400000001080084098070400111111115800345660800322000080",
builder.buildARQCRequest_padded(data, iad)
);
}


}
Loading