Added a padding option to cryptogram builder #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
note: verify CVNCPADataBuilder getDefaultARPCRequest ARC Values.
|
I have also added ISO9797 Padding Method 3 in the Latest commit |
barspi
reviewed
Dec 22, 2023
This was referenced Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes:
added Padding Method interface
added a buildARQCRequest method with PaddingMethod paramater to return Cryptograms data with specified padding
added CPA or Common Payment Application Cryptogram Specs
added fix for IssuerApplicationData does not match if iad is lowercase
added tests
fix typos/text
note:
i am not entirely sure about the getDefaultARPCRequest return for CPA CryptogramSpecs so i set it to Ascii Hex String 3030 for approved and 3031 for declined.