Refactor additional amounts #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AdditionalAmountTypeConverter
…er under iso package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving the additional amounts lib in
modules/cmfto allow for more flexible amount type handling (storing String internally instead of enums), and also adding anAdditionalAmountTypeConverterinterface so converters to/from CMF values can be implemented.The following classes in the
cmfpackage have been deprecated in favor of more generic ones in anisopackage.AdditionalAmountAdditionalAmountsWrapperThe new
AdditionalAmountsWrapperunder theorg.jpos.isopackage is preferred, and a new, more specificCMFAdditonalAmounthas been added (extending from the genericorg.jpos.iso.AdditionalAmount.The idea is to have other specific ones in other libraries, such as a
MastercardAdditionalAmountthat can be used together with the correspondingAdditionalAmountTypeConverter.