Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix in DBManager criteriaQuery to consider all filters #282

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Fix in DBManager criteriaQuery to consider all filters #282

merged 1 commit into from
Sep 13, 2023

Conversation

jrfinc
Copy link
Contributor

@jrfinc jrfinc commented Sep 13, 2023

Continuation of #281.
In some cases, filters where not being considered.

@ar ar merged commit 34e0c82 into master Sep 13, 2023
10 of 14 checks passed
@alcarraz
Copy link
Contributor

Isn't this ignoring the internalFilters parameter?

@jrfinc
Copy link
Contributor Author

jrfinc commented Sep 14, 2023

You are right! Will fix. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ar ar ar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrfinc @alcarraz @ar