Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip BinLogTest on OSX due to lock contention performance issues #151

Closed
wants to merge 1 commit into from

Conversation

jameshilliard
Copy link
Contributor

@jameshilliard jameshilliard commented May 7, 2020

This test takes about 20 minutes to run on OSX due to OSX having very bad performance under high contention locking between multiple threads.

@ar
Copy link
Member

ar commented May 7, 2020

Test barely takes a few minutes in macOS.

I wrote this test while coding BinLog stuff, I'm OK reducing the log size (we don't need 100k entries, probably 10k is OK), but I don't think it's a good idea to just ignore the whole test.

<tps>tps=422, peak=422, avg=422.05</tps>
    100000 000000100000
BUILD SUCCESSFUL in 2m 19s

@ar ar closed this May 7, 2020
@jameshilliard
Copy link
Contributor Author

Test barely takes a few minutes in macOS.

What are the specs on your system?

@ar
Copy link
Member

ar commented May 7, 2020

I just ran this in a MacBook Pro (Retina, 15-inch, Late 2013) 2.3 GHz Intel Core i7 with SDRAM, 16GB RAM. Probably faster in my office's one, this one is old.

@jameshilliard
Copy link
Contributor Author

Think I tracked it down, I was off on the root cause, #152 should hopefully be correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants